*: downgrade grpc to v1.46.0 #88745
Merged
*: downgrade grpc to v1.46.0 #88745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Looks like we did a prior bump from 1.46 to 1.47 as well, which we'll have to revert. Will update shortly. |
pav-kv
approved these changes
Sep 26, 2022
erikgrinaker
force-pushed
the
grpc-revert
branch
from
1c530a8
to
e1b3bb2
Compare
erikgrinaker
changed the title
This was referenced Sep 26, 2022
nvanbenschoten
approved these changes
Sep 26, 2022
erikgrinaker
force-pushed
the
grpc-revert
branch
from
e1b3bb2
to
18ad420
Compare
|
bors r=pavelkalinnikov,nvanbenschoten |
|
Build failed (retrying...): |
|
Merge conflict. |
This downgrades gRPC from v1.49.0 back down to v1.46.0, due to several test failures suspected to be caused by the upgrade (in particular `kv/splits/nodes=3/quiesce=*`). Release note: None
erikgrinaker
force-pushed
the
grpc-revert
branch
from
18ad420
to
748d107
Compare
|
bors retry |
|
Build succeeded: |
This was referenced Sep 27, 2022
craig bot
pushed a commit
that referenced
this pull request
Dec 19, 2022
93867: go.mod: upgrade grpc to v1.51.0 r=erikgrinaker a=erikgrinaker This upgrade contains a number of bugfixes, including crashes bugs. A previous upgrade to v1.49.0 had to be rolled back because of `kv/splits/nodes=3` roachtest failures. This no longer fails with v1.51.0. Resolves #81227. Touches #88745. Epic: none Release note: None Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This downgrades gRPC from v1.49.0 back down to v1.46.0, due to several
test failures suspected to be caused by the upgrade (in particular
kv/splits/nodes=3/quiesce=*).Resolves #88678.
Resolves #88658.
Release note: None